-
Notifications
You must be signed in to change notification settings - Fork 145
v10 #748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v10 #748
Conversation
|
Since the addition of |
|
@TPS Did you have anything in mind? |
|
|
@TPS I'm not sure what's going on here but I can't see either of those comments. Did you submit a review? |
|
@andrews05 Yes: they're just requests to convert "keep all metadata" → "keep all other metadata" the 2× it appears, to make the chunk handling clearer. |
|
@TPS Make sure you go back to the top and click "Submit Review" after adding comments, otherwise they won't be visible. |
I think I got it from the website UI. Couldn't figure out how via the app. 🤷🏾♂️ |
9824474 to
3f70895
Compare
|
@TPS Thanks, I see them now! I've made some further changes to the strip help to incorporate your suggestion as well as mentioning caBX being stripped. |
|
Neat, thanks for taking care of this! ❤️ I think we should incorporate the changes implemented by #745 to the changelog, but other than that this looks good to me. |
59ce779 to
36c0615
Compare
|
@AlexTMjugador Done. I've also moved all the global lints from lib and main into Cargo.toml (and sorted them alphabetically). |
AlexTMjugador
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, good catch on moving the lints to the Cargo manifest! Let's go ahead with this 🚀
No description provided.