Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@andrews05
Copy link
Collaborator

No description provided.

@TPS
Copy link

TPS commented Dec 1, 2025

Since the addition of iDOT stripping, maybe 1 add'l clarifying word a couple places might be helpful? 🙇🏾‍♂️

@andrews05
Copy link
Collaborator Author

@TPS Did you have anything in mind?

@TPS
Copy link

TPS commented Dec 1, 2025

@TPS Did you have anything in mind?

#748 (comment) & #748 (comment)

@andrews05
Copy link
Collaborator Author

@TPS I'm not sure what's going on here but I can't see either of those comments. Did you submit a review?

@TPS
Copy link

TPS commented Dec 1, 2025

@andrews05 Yes: they're just requests to convert "keep all metadata" → "keep all other metadata" the 2× it appears, to make the chunk handling clearer.

@andrews05
Copy link
Collaborator Author

@TPS Make sure you go back to the top and click "Submit Review" after adding comments, otherwise they won't be visible.

@TPS
Copy link

TPS commented Dec 2, 2025

@TPS Make sure you go back to the top and click "Submit Review" after adding comments, otherwise they won't be visible.

I think I got it from the website UI. Couldn't figure out how via the app. 🤷🏾‍♂️

@andrews05 andrews05 force-pushed the release-10 branch 2 times, most recently from 9824474 to 3f70895 Compare December 2, 2025 07:30
@andrews05
Copy link
Collaborator Author

@TPS Thanks, I see them now!

I've made some further changes to the strip help to incorporate your suggestion as well as mentioning caBX being stripped.

@AlexTMjugador
Copy link
Member

AlexTMjugador commented Dec 6, 2025

Neat, thanks for taking care of this! ❤️ I think we should incorporate the changes implemented by #745 to the changelog, but other than that this looks good to me.

@andrews05 andrews05 force-pushed the release-10 branch 2 times, most recently from 59ce779 to 36c0615 Compare December 6, 2025 19:45
@andrews05
Copy link
Collaborator Author

@AlexTMjugador Done. I've also moved all the global lints from lib and main into Cargo.toml (and sorted them alphabetically).

Copy link
Member

@AlexTMjugador AlexTMjugador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good catch on moving the lints to the Cargo manifest! Let's go ahead with this 🚀

@AlexTMjugador AlexTMjugador merged commit 58eec39 into oxipng:master Dec 6, 2025
11 checks passed
@andrews05 andrews05 deleted the release-10 branch December 6, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants