Ensure evaluator returns no result when all candidates are too large #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @andrews05 for the fast response. Just testing the CI binary now. 🙏 Update: LGTM; from my limited testing- this is a win!! Thanks again! ✨ |
AlexTMjugador
approved these changes
Dec 17, 2025
Member
AlexTMjugador
left a comment
There was a problem hiding this comment.
Thank you for the PR, it looks good to me!
66f924c to
1c85de2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small crack in the fast evaluation logic where a phase 2 candidate's IDAT could be compressed below the best size from phase 1, but the estimated output size (which includes chunks like PLTE) was above. This candidate could end up getting returned from the evaluator if no other filter actually did compress better, and would then be used for the final compression even though the phase 1 candidate was actually better.
The issue could potentially affect small, indexed images in
--fastmode (o2 and below).Fixes #753.