render/font: Enforce default truetype font height for Height() #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #209 +/- ##
=======================================
Coverage 95.01% 95.02%
=======================================
Files 143 143
Lines 6344 6346 +2
=======================================
+ Hits 6028 6030 +2
Misses 285 285
Partials 31 31
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Contributor
|
Will merge after tests pass. |
200sc
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a font is generated from a fontgenerator that has fontsize as 0 it will overwrite it with the value of 12 (as per truetype).
However the height method on a font calls the gen referenced(which is a pointer so could change which is interesting in and of itself). At font generation time the size change is only set on the font itself rather than the generator so we return a 0 instead of a 12 prior to this change.