Add "requests" package also to requirements #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikovic
approved these changes
Nov 25, 2019
Member
|
@jmikovic This is wrong fix. The requirement should not be inside the leapp-repository as nothing from leapp-repository requires it. The issue is that requirements of leapp have not been installed. This should be fixed. |
bocekm
added a commit
to bocekm/leapp
that referenced
this pull request
Dec 11, 2019
The requests package was missing when running leapp-repository unit tests - leapp framework was being installed by leapp-repository makefile as a dependency, but without this dependency of leapp framework. That caused an incorrect workaround on the leapp-repository side: oamg/leapp-repository#410
bocekm
added a commit
to bocekm/leapp-repository
that referenced
this pull request
Dec 11, 2019
This reverts commit bb7ac2c. That commit was an incorrect workaround on the leapp-repository side. It should have been fixed on the leapp framework side. The 'requests' package was missing when running leapp-repository unit tests. It was caused when leapp framework was being installed as a dependency by leapp-repository makefile, but without this 'requests' dependency of leapp framework itself. It's fixed by oamg/leapp#587.
pirat89
pushed a commit
to oamg/leapp
that referenced
this pull request
Dec 11, 2019
The requests package was missing when running leapp-repository unit tests - leapp framework was being installed by leapp-repository makefile as a dependency, but without this dependency of leapp framework. That caused an incorrect workaround on the leapp-repository side: oamg/leapp-repository#410
pirat89
pushed a commit
that referenced
this pull request
Dec 12, 2019
This reverts commit bb7ac2c. That commit was an incorrect workaround on the leapp-repository side. It should have been fixed on the leapp framework side. The 'requests' package was missing when running leapp-repository unit tests. It was caused when leapp framework was being installed as a dependency by leapp-repository makefile, but without this 'requests' dependency of leapp framework itself. It's fixed by oamg/leapp#587.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.