Thanks to visit codestin.com
Credit goes to github.com

Skip to content

stdlib: check_output should be call #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pirat89 merged 1 commit into from
Jan 8, 2019
Merged

stdlib: check_output should be call #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion leapp/libraries/stdlib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import os


def check_output(args, split=True):
def call(args, split=True):
"""
Call an external program, capture and automatically utf-8 decode its ouput.
Then, supress output to stderr and redirect to /dev/null.
Expand Down
10 changes: 5 additions & 5 deletions tests/scripts/test_stdlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
from leapp.libraries.stdlib import check_output
from leapp.libraries.stdlib import call


def test_check_single_line_output():
a_command = ['echo', 'This a single line test!']
assert check_output(a_command) == [u'This a single line test!']
assert call(a_command) == [u'This a single line test!']


def test_check_single_line_output_no_split():
a_command = ['echo', 'This a single line No Split test!']
assert check_output(a_command, split=False) == u'This a single line No Split test!\n'
assert call(a_command, split=False) == u'This a single line No Split test!\n'


def test_check_multiline_output():
a_command = ['echo', 'This a multi-\nline test!']
assert check_output(a_command) == [u'This a multi-', u'line test!']
assert call(a_command) == [u'This a multi-', u'line test!']


def test_check_multiline_output_no_split():
a_command = ['echo', 'This a multi-\nline No Split test!']
assert check_output(a_command, split=False) == u'This a multi-\nline No Split test!\n'
assert call(a_command, split=False) == u'This a multi-\nline No Split test!\n'