Fix _get_actor #548
Merged
Fix _get_actor #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
return valid actor when there is another actor which name is a substring of the actor in context. E.g: "persistentnetnames" vs. "persistentnetnamesdisable"
Contributor
|
LGTM. |
drehak
approved these changes
Aug 15, 2019
pirat89
added a commit
to pirat89/leapp
that referenced
this pull request
Oct 24, 2019
## Packaging - Add the /var/log/leapp directory to the leapp RPM ## Framework ### Fixes - Handle string types in compatible way - Allow testing actors (run unit & component tests) with workflow config models ### Enhancements - Stop adding 'process-end' audit entry (oamg#538) - Introduce report composability, remove renders (oamg#543) - Introduce answerfile generation & usage - Add additional metadata (hash) to reporting messages to be able to identify them uniquely ## Leapp ### Fixes - Various fixes in desplaying of generated reports - Show help message for proper subcommand ### Enhancements - Introduce report composability, remove renders (oamg#543) - Introduce answerfile generation & usage ## Snactor ### Fixes - Fix processing of actors when two actors start with the same name (oamg#548) ### Enhancements - Add sanity-check command ## stdlib ### Fixes ### Enhancements - improve failed command error message - log external command errors to audit
Merged
pirat89
added a commit
to pirat89/leapp
that referenced
this pull request
Oct 24, 2019
## Packaging - Add the /var/log/leapp directory to the leapp RPM ## Framework ### Fixes - Handle string types in compatible way - Allow testing actors (run unit & component tests) with workflow config models ### Enhancements - Stop adding 'process-end' audit entry (oamg#538) - Introduce report composability, remove renders (oamg#543) - Introduce answerfile generation & usage - Add additional metadata (hash) to reporting messages to be able to identify them uniquely ## Leapp ### Fixes - Various fixes in displaying of generated reports - Show help message for proper subcommand ### Enhancements - Introduce report composability, remove renders (oamg#543) - Introduce answerfile generation & usage ## Snactor ### Fixes - Fix processing of actors when two actors start with the same name (oamg#548) ### Enhancements - Add sanity-check command ## stdlib ### Fixes ### Enhancements - improve failed command error message - log external command errors to audit
pirat89
added a commit
that referenced
this pull request
Oct 24, 2019
## Packaging - Add the /var/log/leapp directory to the leapp RPM ## Framework ### Fixes - Handle string types in compatible way - Allow testing actors (run unit & component tests) with workflow config models ### Enhancements - Stop adding 'process-end' audit entry (#538) - Introduce report composability, remove renders (#543) - Introduce answerfile generation & usage - Add additional metadata (hash) to reporting messages to be able to identify them uniquely ## Leapp ### Fixes - Various fixes in displaying of generated reports - Show help message for proper subcommand ### Enhancements - Introduce report composability, remove renders (#543) - Introduce answerfile generation & usage ## Snactor ### Fixes - Fix processing of actors when two actors start with the same name (#548) ### Enhancements - Add sanity-check command ## stdlib ### Fixes ### Enhancements - improve failed command error message - log external command errors to audit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return valid actor when there is another actor which name
is a substring of the actor in context.
E.g:
"persistentnetnames" vs. "persistentnetnamesdisable"