-
Notifications
You must be signed in to change notification settings - Fork 79
Unify leapp-preupgrade and leapp-upgrade logs #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
|
Can one of the admins verify this patch? |
|
Well if you would do this now, this would mean you would have to update all the documentation. Also would this clash a bit with C2R - While I am pretty sure why you think we need this, I think there might be an alternative solution. I think it might work if you would set leapp.logger._logger to None after you're done. |
|
Well iiuc clash with convert2rhel is not something we have to worry about anymore, as they won't be using leapp for conversions. |
Instead of having a dedicated leapp-CMDNAME file for each command log latest run as leapp-upgrade.log.
45a0e0b to
b084a71
Compare
|
/rerun 850 |
|
Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3656342 |
|
Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3656353 |
|
Testing Farm request for 7to8/3656353,3656342 regression testing has been created. Once finished, results should be available here. |
|
Testing Farm request for 8to9/3656353,3656342 regression testing has been created. Once finished, results should be available here. |
|
This one came in pair with oamg/leapp-repository#850 which is now closed in favor of #764 |
Instead of having a dedicated leapp-CMDNAME file for
each command log latest run as leapp.log.