Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@fernflower
Copy link
Member

Instead of having a dedicated leapp-CMDNAME file for
each command log latest run as leapp.log.

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
If you want to re-run tests or request review, you can use following commands as a comment:

  • leapp-ci build to run copr build and e2e tests in OAMG CI
  • review please to notify leapp developers of review request
  • /packit copr-build to submit a public copr build using packit

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

@centos-ci
Copy link

Can one of the admins verify this patch?

@vinzenz
Copy link
Member

vinzenz commented Mar 9, 2022

Well if you would do this now, this would mean you would have to update all the documentation. Also would this clash a bit with C2R - While I am pretty sure why you think we need this, I think there might be an alternative solution. I think it might work if you would set leapp.logger._logger to None after you're done.

@fernflower
Copy link
Member Author

fernflower commented Mar 9, 2022

Well iiuc clash with convert2rhel is not something we have to worry about anymore, as they won't be using leapp for conversions.
If we don't have doc freeze I'd rather have 1 log file, but maybe leapp.log is a very bad name, yeah. How about keeping leapp-upgrade.log for both preupgrade and upgrade? Or maybe just leapp-run.log?

Instead of having a dedicated leapp-CMDNAME file for
each command log latest run as leapp-upgrade.log.
@fernflower
Copy link
Member Author

/rerun 850

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3656342

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Copr build succeeded: https://copr.fedorainfracloud.org/coprs/build/3656353

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Testing Farm request for 7to8/3656353,3656342 regression testing has been created. Once finished, results should be available here.
Full pipeline log.

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Testing Farm request for 8to9/3656353,3656342 regression testing has been created. Once finished, results should be available here.
Full pipeline log.

@fernflower
Copy link
Member Author

This one came in pair with oamg/leapp-repository#850 which is now closed in favor of #764

@fernflower fernflower closed this Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants