Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Save actor tracebacks in leapp.db #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pirat89 merged 3 commits into from
Jun 26, 2023
Merged

Save actor tracebacks in leapp.db #832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
792ba67
Save actor tracebacks in leapp.db
fernflower Jun 7, 2023
d1f8c4b
[squashme] Log actor crash
fernflower Jun 22, 2023
7924327
[squashme] Put trace in the details
fernflower Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion leapp/messaging/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@ def report_error(self, message, severity, actor, details):
time=datetime.datetime.now())
self._do_produce(model, actor, self._errors)

def report_stacktrace(self, message, trace, actorname):
model = ErrorModel(message=message, details=trace, actor=actorname, severity="fatal",
time=datetime.datetime.now())
self._do_produce(model, actorname, self._errors)

def request_stop_after_phase(self):
"""
If called, it will cause the workflow to stop the execution after the current phase ends.
Expand Down Expand Up @@ -222,7 +227,7 @@ def _do_produce(self, model, actor, target, stored=True):
data = json.dumps(model.dump(), sort_keys=True)
message = {
'type': type(model).__name__,
'actor': type(actor).name,
'actor': type(actor).name if not isinstance(actor, str) else actor,
'topic': model.topic.name,
'stamp': datetime.datetime.utcnow().isoformat() + 'Z',
'phase': os.environ.get('LEAPP_CURRENT_PHASE', 'NON-WORKFLOW-EXECUTION'),
Expand Down
7 changes: 6 additions & 1 deletion leapp/workflows/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,8 +338,13 @@ def run(self, context=None, until_phase=None, until_actor=None, skip_phases_unti
config_model=config_model, skip_dialogs=skip_dialogs)
try:
instance.run()
except BaseException:
except BaseException as exc:
self._unhandled_exception = True
messaging.report_stacktrace(message=exc.message,
trace=exc.exception_info,
actorname=actor.name)
current_logger.error('Actor {actor} has crashed: {trace}'.format(actor=actor.name,
trace=exc.exception_info))
raise

self._stop_after_phase_requested = messaging.stop_after_phase or self._stop_after_phase_requested
Expand Down