Add an ERROR report group #838
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
To launch regression testing public members of oamg organization can leave the following comment:
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
matejmatuska
commented
Aug 9, 2023
| } | ||
|
|
||
|
|
||
| def is_inhibitor(message): |
Member
Author
There was a problem hiding this comment.
Need to keep this as it's a public API.
c475b7f to
391b51a
Compare
Linter started giving new warnings on Python 3.9, let's make it happy again.
Currently there is no straightforward way to identify whether a report is an ordinary report or an error report (report generated from an error). An `ERROR` group is introduced in `leapp.reporting.Groups.ERROR` which is used to group error reports. This is utilized in the leapp output to show the number of error reports in the summary. Also error reports in `leapp-report.txt` are now followed by a "(error)" string similar to inhibitors. Jira: OAMG-9532
dba3c16 to
9777da7
Compare
Member
Author
Example outputsOrdinary outputOutput with an errorOutput with an inhibitorleapp-report.json entryleapp-report.txt entry |
Member
Author
|
This is included in #840 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no straightforward way to identify whether a report is an ordinary report or an error report (report generated from an error).
An
ERRORgroup is introduced inleapp.reporting.Groups.ERRORwhich is used to group error reports. This is utilized in the leapp output to show the number of error reports in the summary. Also error reports inleapp-report.txtare now followed by a "(error)" string similar to inhibitors.Jira: OAMG-9532