Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix leaking FDs in the run (_call) function #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pirat89 merged 2 commits into from
Aug 12, 2024
Merged

Fix leaking FDs in the run (_call) function #880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3642b1e
libraries.stdlib.call: fix leaking epoll FD
t184256 Aug 12, 2024
88aedf1
libraries.stdlib.call: close two more FDs
t184256 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion leapp/libraries/stdlib/call.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,9 @@ def _call(command, callback_raw=lambda fd, value: None, callback_linebuffered=la
elif stdin is not None:
raise TypeError('stdin has to be either a file descriptor or string, not "{!s}"'.format(type(stdin)))

ep = EventLoop()
pid = os.fork()
if pid > 0:
ep = EventLoop()
# Since pid > 0, we are in the parent process, so we have to close the write-end
# file descriptors
os.close(wstdout)
Expand Down Expand Up @@ -202,6 +202,8 @@ def _call(command, callback_raw=lambda fd, value: None, callback_linebuffered=la
# Wait for the child to finish
pid, status = os.wait()
ep.close()
os.close(stdout)
os.close(stderr)

# The status variable is a 16 bit value, where the lower octet describes
# the signal which killed the process, and the upper octet is the exit code
Expand Down