-
Notifications
You must be signed in to change notification settings - Fork 79
Increase resource limits to prevent crashes #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,4 @@ | ||
| from leapp.utils.workarounds import apply_workarounds | ||
|
|
||
| VERSION = "0.18.0" | ||
| FULL_VERSION = VERSION | ||
| from leapp.__version__ import VERSION, FULL_VERSION | ||
|
|
||
| apply_workarounds() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| VERSION = "0.18.0" | ||
| FULL_VERSION = VERSION |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,9 @@ | ||
| import leapp.utils.workarounds.mp | ||
| import leapp.utils.workarounds.fqdn | ||
| import leapp.utils.workarounds.resources | ||
|
|
||
|
|
||
| def apply_workarounds(): | ||
| leapp.utils.workarounds.mp.apply_workaround() | ||
| leapp.utils.workarounds.fqdn.apply_workaround() | ||
| leapp.utils.workarounds.resources.apply_workaround() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import resource | ||
| from leapp.exceptions import FrameworkInitializationError | ||
|
|
||
|
|
||
| def apply_workaround(): | ||
| """ | ||
| Set resource limits for the maximum number of open file descriptors and the maximum writable file size. | ||
|
|
||
| :raises: `CommandError` if the resource limits cannot be set | ||
| """ | ||
|
|
||
| def set_resource_limit(resource_type, soft, hard): | ||
| rtype_string = ( | ||
| 'open file descriptors' if resource_type == resource.RLIMIT_NOFILE | ||
| else 'writable file size' if resource_type == resource.RLIMIT_FSIZE | ||
| else 'unknown resource' | ||
| ) | ||
| try: | ||
| resource.setrlimit(resource_type, (soft, hard)) | ||
| except ValueError as err: | ||
| raise FrameworkInitializationError( | ||
| 'Unable to set the required soft limit of resource due to system restrictions. ' | ||
| 'This limit is necessary to prevent the program from crashin. ' | ||
| 'Resource type: {}, error: {}'.format(rtype_string, err) | ||
| ) | ||
| except OSError as err: | ||
| raise FrameworkInitializationError( | ||
| 'Failed to set resource limit. Resource type: {}, error: {}'.format(rtype_string, err) | ||
| ) | ||
|
|
||
| soft_nofile, _ = resource.getrlimit(resource.RLIMIT_NOFILE) | ||
| soft_fsize, _ = resource.getrlimit(resource.RLIMIT_FSIZE) | ||
| nofile_limit = 1024 * 16 | ||
| fsize_limit = resource.RLIM_INFINITY | ||
|
|
||
| if soft_nofile < nofile_limit: | ||
| set_resource_limit(resource.RLIMIT_NOFILE, nofile_limit, nofile_limit) | ||
|
|
||
| if soft_fsize != fsize_limit: | ||
| set_resource_limit(resource.RLIMIT_FSIZE, fsize_limit, fsize_limit) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.