ui: Add custom port mapping form #203
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfranczy
reviewed
Jun 21, 2017
cockpit/leapp.html
Outdated
| }); | ||
|
|
||
| $("#map-new-port-show").click(function(){ | ||
| $("#map-new-port-form").find("input[type=text]").val("") |
There was a problem hiding this comment.
please use semicolons, like everywhere in the code, probably we should use strict mode. Maybe it's a good idea to assign #map-new-port-form to some var?
mfranczy
reviewed
Jun 21, 2017
cockpit/leapp.html
Outdated
| event.preventDefault() | ||
| $("#map-new-port-form").find("input[type=text]").parent().removeClass("has-error") | ||
|
|
||
| src_element = $("#add-port-src") |
There was a problem hiding this comment.
it's a common practice to add $ before var name in that case, it's useful because it informs you that you keep jQuery selection, so would be great if you could add this, btw why you don't use var here?
vinzenz
approved these changes
Jun 22, 2017
Member
|
Already merged with #209 |
pirat89
added a commit
to pirat89/leapp
that referenced
this pull request
Jul 15, 2019
Packaging - Fix URL and Source0 in the SPEC file ===================================================================== Framework * Fixes - Add workround patch for the multiprocessing library - Exit non-zero on unhandled exceptions and errors - Fix actor library loading, so libs do not have to be imported in lexicographical order - Fix buf with mode inheritance and list field (oamg#203) - Fix warning about membership check of models when (oamg#503) - Load checkpoint ordered by `id` instead of timestamp to prevent issues with changed timezone (oamg#499) - Log on the ERROR level by default instead of DEBUG - Print usage to stderr * Enhancements - Add phase name checking to workflow parameters - Add the fetch_upgrade_report_raw() function to obtain raw report data - Create a dynamic configuration phase that allows creation of configuration for repository workflow - Functionalite getting actor and phase names when working with a workflow ===================================================================== Leapp * Fixes - Add checks of arguments for cmdline parameters - Load checkpoint ordered by `id` instead of timestamp to prevent issues with changed timezone (oamg#499) * Enhancements - Add JSON report generation - Add the preupgrade subcommand for the leapp tool that stops workflow execution after the Reports phase and display info about generated report ===================================================================== Snactor * Fixes - Add a simple logger to snactor discover command to avoid spurious output about missing logger - Add checks of arguments for cmdline parameters - Exit non-zero on unhandled exceptions and errors - Load checkpoint ordered by `id` instead of timestamp to prevent issues with changed timezone (oamg#499) ===================================================================== stdlib * Fixes - Add checks of arguments for cmdline parameters * Enhancements - Log output of commands to logfile (oamg#520) - stdlib: add option to `run()` to ignore exit code ===================================================================== Modifications - introduced conftest.py to utilize fixture mechanism, so fixture doesn't have to be imported explicitly in tests. - refactoring to satisfy linters
Merged
pirat89
added a commit
that referenced
this pull request
Jul 15, 2019
Packaging - Fix URL and Source0 in the SPEC file ===================================================================== Framework * Fixes - Add workround patch for the multiprocessing library - Exit non-zero on unhandled exceptions and errors - Fix actor library loading, so libs do not have to be imported in lexicographical order - Fix buf with mode inheritance and list field (#203) - Fix warning about membership check of models when (#503) - Load checkpoint ordered by `id` instead of timestamp to prevent issues with changed timezone (#499) - Log on the ERROR level by default instead of DEBUG - Print usage to stderr * Enhancements - Add phase name checking to workflow parameters - Add the fetch_upgrade_report_raw() function to obtain raw report data - Create a dynamic configuration phase that allows creation of configuration for repository workflow - Functionalite getting actor and phase names when working with a workflow ===================================================================== Leapp * Fixes - Add checks of arguments for cmdline parameters - Load checkpoint ordered by `id` instead of timestamp to prevent issues with changed timezone (#499) * Enhancements - Add JSON report generation - Add the preupgrade subcommand for the leapp tool that stops workflow execution after the Reports phase and display info about generated report ===================================================================== Snactor * Fixes - Add a simple logger to snactor discover command to avoid spurious output about missing logger - Add checks of arguments for cmdline parameters - Exit non-zero on unhandled exceptions and errors - Load checkpoint ordered by `id` instead of timestamp to prevent issues with changed timezone (#499) ===================================================================== stdlib * Fixes - Add checks of arguments for cmdline parameters * Enhancements - Log output of commands to logfile (#520) - stdlib: add option to `run()` to ignore exit code ===================================================================== Modifications - introduced conftest.py to utilize fixture mechanism, so fixture doesn't have to be imported explicitly in tests. - refactoring to satisfy linters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.