FIX: improper y-limit in Stream/Trace plot when 0-value trace exists#3665
Open
Dengda98 wants to merge 3 commits intoobspy:masterfrom
Open
FIX: improper y-limit in Stream/Trace plot when 0-value trace exists#3665Dengda98 wants to merge 3 commits intoobspy:masterfrom
Dengda98 wants to merge 3 commits intoobspy:masterfrom
Conversation
Contributor
|
What happens when you plot equal_scale=False to the plot command? |
Author
|
The plot with equal_scale=False looks fine, probably the default ylim issure only affect this part. obspy/obspy/imaging/waveform.py Lines 822 to 830 in 1b4da27 |
Contributor
|
@Dengda98 didn't forget you :) Just trying to get my ideas together on how to approach this in the most generalized way (your idea is very valid, trying to think if it could happen e.g. if not "all zeros", but "all the same value", for example, etc?) |
Author
|
@ThomasLecocq Thanks! Bug reproduce (same value) from obspy import *
st = read()
tr2 = st[0].copy()
tr2.data[:] = 1e8 # all the same value, and large enough to cover the normal data
tr2.stats.channel += '2' # just for distinguish
# for tr in st:
# tr.data[:] *= 1e-8
st += Stream(tr2)
st.plot() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Hi ObsPy !
To explain this bug, see the tiny script below,
In this figure, the y-limit of all axes are set to [-0.05, 0.05], which is probably the default margin used by matplotlib when plotting all-zero data. If the range of other traces is smaller than [-0.05, 0.05], an improper y-limit will be set in the function
WaveformPlotting.__plot_set_y_ticks().To solve this, I just add if-statements to set an extremely small y-limit for this specific issure. This issue might be extremely unlikely to occur in real data, but I encountered it during my synthetic seismogram research, so I submitted this PR.
PR Checklist
masterfor new features,maintenance_...for bug fixesready for reviewlabel when you are ready for the PR to be reviewed.