add torchvision object detector support #368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcakyon
reviewed
Jan 28, 2022
fcakyon
reviewed
Jan 28, 2022
fcakyon
reviewed
Jan 28, 2022
fcakyon
reviewed
Jan 28, 2022
fcakyon
reviewed
Jan 28, 2022
fcakyon
reviewed
Jan 28, 2022
fcakyon
reviewed
Jan 28, 2022
fcakyon
reviewed
Jan 28, 2022
-classes yerine COCO_CLASSES olarak düzeltildi. -category_remapping fonksiyonu yazılarak category id değişkeni yazıldı -mask hatası çözülemedi. test_torchvision.py: -assert kodları daha sonra eklenmek üzere kaldırıldı torchvision.py - classes yerine COCO_CLASSES ismi tercih edildi.
Contributor
Author
|
https://github.com/kadirnar/sahi/blob/torchvision/sahi/model.py#L786-L789 Buradaki kodların yazılması hakkında yardıma ihtiyacım var. Şimdilik mask işlemin yapılmasını istemiyorum. Object detection kodlarının başarılı şekilde çalışıp çalışmadığını kontrol etmek istiyorum. |
SAHI'ye torchvision desteği eklendi :)
Contributor
Author
|
@fcakyon SAHI algoritmasına TorchVision kütüphanesi başarılı şekilde eklenmiştir. https://github.com/obss/sahi/issues/275 sorusuna bu branch'i yönlendirebilirsiniz. Bundan sonra yapılacaklar:
|
- model.py dosyasındaki gereksiz kodlar silindi. - test_torchvision.py dosyasında etiket bilgileri girerek test kodları yazıldı.
- model.py dosyasındaki çakışan kod hatası düzeltildi.
- resim yolları github'a göre ayarlandı.
- reformat kodları çalıştırıldı.
Collaborator
devrimcavusoglu
requested changes
May 31, 2022
Member
devrimcavusoglu
left a comment
There was a problem hiding this comment.
Throughout all of the files typo correction is required. Correct the typo in naming from FASTERCNN -> FASTERRCNN
Collaborator
|
Closing this PR in favor of #486. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check this list for supported detectors: https://pytorch.org/vision/stable/models.html#id63
fixes https://github.com/obss/sahi/issues/275