fix(runtest): path interpretation in subdirectory #12251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2242029 to
14092e0
Compare
This was referenced Aug 21, 2025
rgrinberg
approved these changes
Aug 23, 2025
Signed-off-by: Ali Caglayan <[email protected]>
When we interpret source paths we need to make sure they have been adjusted with respect to the current working directory. Signed-off-by: Ali Caglayan <[email protected]>
14092e0 to
2b64734
Compare
maiste
added a commit
that referenced
this pull request
Aug 25, 2025
* test: dune runtest in subdirectory * fix(runtest): path interpretation in subdirectory Co-authored-by: Ali Caglayan <[email protected]>
maiste
added a commit
to maiste/opam-repository
that referenced
this pull request
Aug 25, 2025
CHANGES: ### Fixed - Fix `runtest-js` mistakenly depending on `byte` (fixes ocaml/dune#12243, ocaml/dune#12242, @vouillon and @Alizter) - Fix the interpretation of paths in `dune runtest` when running from within a subdirectory. (ocaml/dune#12251, fixes ocaml/dune#12250, @Alizter) ### Changed - Revert formatting change introduced in 3.20.0 making long lists in s-expressions fill the line instead of formatting them in a vertical way (ocaml/dune#12245, reverts ocaml/dune#10892, @nojb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue observed in #12250. The issue was that source paths were not being adjusted correctly with respect to the current working directory.
The first commit adds a test demonstrating the issue, which was introduced in 971584f.
The second commit adds a fix which adjusts the source path accordingly.