Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change to use Picos for scheduler interop #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Change to use Picos for scheduler interop #136

wants to merge 1 commit into from

Conversation

@polytypic
Copy link
Collaborator

@polytypic polytypic commented Oct 2, 2023 •
edited
Loading

This PR changes Kcas to use Picos instead of DLA and DLT for scheduler interop.

⚠️ This must obviously not be merged before at least a first release of Picos has been published on opam, but this should be ready enough for preliminary review.

@polytypic polytypic force-pushed the change-to-use-picos branch 4 times, most recently from a1ee8e0 to f43c98d Compare October 2, 2023 17:34
@polytypic polytypic mentioned this pull request Oct 2, 2023
Closed
@polytypic polytypic force-pushed the change-to-use-picos branch 5 times, most recently from fe7be98 to 62ed6e4 Compare October 24, 2023 12:18
@polytypic polytypic changed the title WIP: Change to use Picos for scheduler interop Change to use Picos for scheduler interop Oct 24, 2023
@polytypic polytypic marked this pull request as ready for review October 24, 2023 12:24
@polytypic polytypic force-pushed the change-to-use-picos branch from 62ed6e4 to 20d0905 Compare October 24, 2023 12:28
polytypic
polytypic commented Oct 24, 2023
View reviewed changes
kcas.opam.template Outdated
@@ -1 +1,4 @@
doc: "https://ocaml-multicore.github.io/kcas/doc/kcas/Kcas/"
pin-depends: [
[ "picos.dev" "git+https://github.com/ocaml-multicore/picos#2f2af8b2f170a38889211662fdc79bd160d82a69" ]
Copy link
Collaborator Author

@polytypic polytypic Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pin-depend must be removed before merging.

polytypic
polytypic commented Oct 24, 2023
View reviewed changes
kcas.opam
"backoff" {>= "0.1.0"}
"domain-local-await" {>= "1.0.0"}
"domain-local-timeout" {>= "1.0.0"}
"picos"
Copy link
Collaborator Author

@polytypic polytypic Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should specify a version number.

@polytypic polytypic force-pushed the change-to-use-picos branch 2 times, most recently from f33bd10 to f3405ce Compare October 25, 2023 10:30
@polytypic polytypic force-pushed the change-to-use-picos branch from f3405ce to fec9ff3 Compare November 1, 2023 16:37
@polytypic polytypic force-pushed the change-to-use-picos branch 12 times, most recently from fc4542e to 82dd5b4 Compare December 9, 2023 21:15
@polytypic polytypic force-pushed the change-to-use-picos branch 5 times, most recently from ffea3ef to 3643595 Compare December 10, 2023 15:22
@polytypic polytypic force-pushed the change-to-use-picos branch 3 times, most recently from 4af4e1d to b0a362b Compare December 22, 2023 20:15
@polytypic
Copy link
Collaborator Author

polytypic commented Sep 20, 2024

This has been replaced by work in #204.

@polytypic polytypic closed this Sep 20, 2024
@polytypic polytypic deleted the change-to-use-picos branch September 20, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@polytypic