@Gemxi Since your your branch is based on the docking branch, you need to base your PR on the docking branch.

You can change it by clicking the Edit button at the very top of this PR (it's up by the title of the PR.)

@Gemxi Since your your branch is based on the docking branch, you need to base your PR on the docking branch.

You can change it by clicking the Edit button at the very top of this PR (it's up by the title of the PR.)

I did. Thank you!

Hello,
Thanks for your PR.
Could you

• (1) ensure the code is following the same coding style as the neighboring file.
• (2) confirm that you have read Fix event capture in multi-window applications on macOS #8644 and understand the reason for initial change. Ping @BingoXuan

Sorry I seldomly use the Mac so it's difficult for me to understand what's going on here.

For mouse events sent via ImGui_ImplOSX_AddTrackingArea, view.window is always the main viewport as passed to ImplOSX_Init. Therefore FindViewportByPlatformHandle(view.window)->PlatformHandleRaw == event.window fails.

Shouldn't the entire check just be this instead?

// Only process events from windows containing an ImGui viewport
if (!ImGui::FindViewportByPlatformHandle((__bridge void*)event.window))
    return false;

It was my assumption in
#8644 (comment)

But I didn’t test any of this myself. Could you test Christian ?

I booted the Mac and tested this, and pushed ee8fd53. Which matches my initial suggestion and @BingoXuan message posted (which I had overlooked) after I merged their initial version.