Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 22, 2023. It is now read-only.

Fixup for wrapping errors in CLIError constructor #19

Closed
wants to merge 2 commits into from
Closed

Fixup for wrapping errors in CLIError constructor #19

wants to merge 2 commits into from

Conversation

@rizzlesauce
Copy link

This makes it so that this.error(new Error(...)) within oclif
command run() prints nicely, and without a stack trace in
non-debug mode.

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Ross Adamson <r***@r***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

@codecov
Copy link

codecov bot commented Sep 20, 2019 •
edited
Loading

Codecov Report

Merging #19 into master will decrease coverage by 3.62%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   70.54%   66.91%   -3.63%     
==========================================
  Files           7        7              
  Lines         129      133       +4     
  Branches       31       36       +5     
==========================================
- Hits           91       89       -2     
- Misses         27       33       +6     
  Partials       11       11
Impacted Files Coverage Δ
src/errors/cli.ts 62.16% <38.46%> (-13.6%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b690352...baba1c2. Read the comment docs.

@rizzlesauce
Fixup for wrapping errors in CLIError constructor
48cc324 
This makes it so that `this.error(new Error(...))` within oclif
command `run()` prints nicely, and without a stack trace in
non-debug mode.
@rizzlesauce rizzlesauce force-pushed the bugfix/clierror-wrap-error branch from 8aacfd6 to 48cc324 Compare September 20, 2019 02:35
@salesforce-cla
Copy link

Thanks for the contribution! Before we can merge this, we need @rizzlesauce to sign the Salesforce.com Contributor License Agreement.

@rizzlesauce rizzlesauce mentioned this pull request Sep 20, 2019
Closed
@mohoff mohoff mentioned this pull request Dec 4, 2019
Merged
6 tasks
chadian added a commit that referenced this pull request Jun 17, 2020
@chadian @rizzlesauce
Unwrap CLIError from augmenting existing errors in constructor
65e4582 
Thanks @rizzlesauce for your contribution on #19 and highlighting the
augmenting the error. Some of those ideas are pulled into this commit.

Co-authored-by: Ross Adamson <[email protected]>
chadian added a commit that referenced this pull request Jun 24, 2020
@chadian @rizzlesauce
Unwrap CLIError from augmenting existing errors in constructor
ce5920d 
Thanks @rizzlesauce for your contribution on #19 and highlighting the
augmenting the error. Some of those ideas are pulled into this commit.

Co-authored-by: Ross Adamson <[email protected]>
@chadian
Copy link
Contributor

chadian commented Jun 29, 2020

I'm going to close this, thanks for your contribution! Your idea was included on this commit as co-author: ce5920d on #27.

@chadian chadian closed this Jun 29, 2020
@antgonzales
Copy link

@chadian I'm confused, was this problem solved? Here's a test that throws an error:

https://share.getcloudapp.com/7KuPxjg6

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla:signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rizzlesauce @chadian @antgonzales