You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
And prepare to break Lwt_stream.map_exn, which uses this type.
Users of the current map_exn will see:
Warning 3: deprecated: Lwt_stream.map_exn
This function will soon use Lwt.result instead of Lwt_stream.result.
To continue using the present signature, use Lwt_stream.Versioned.map_exn_1
To use the new variant immediately, use Lwt_stream.Versioned.map_exn_2
That's not a fabulous way of making breaking change. I'm pretty sure you could just come up with a better name (wrap_all, for parallel with Lwt.wrap ?) and make the transition like that.
@vasilisp, @Drup Thanks. #293 is how I intend to make breaking changes if we want to keep the name.
But, if map_exn is the wrong name for this function to begin with, fair enough. Then, if we agree on a good name for the new version (will take a look at wrap/wrap_exn later, preoccupied with something), I will only deprecate map_exn and the type and move them to the bottom of the API docs, and keep them there for a very long time. No need for .Versioned in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And prepare to break
Lwt_stream.map_exn, which uses this type.Users of the current
map_exnwill see:cc @c-cube more
resultmeltdown :P