enhance/fix invalid argument exception string payload#368
Merged
aantron merged 2 commits intoocsigen:masterfrom May 23, 2017
domsj:invalid-arg
Merged
enhance/fix invalid argument exception string payload#368aantron merged 2 commits intoocsigen:masterfrom domsj:invalid-arg
aantron merged 2 commits intoocsigen:masterfrom
domsj:invalid-arg
Conversation
aantron
reviewed
May 22, 2017
Collaborator
aantron
left a comment
There was a problem hiding this comment.
Thanks. Lwt has a lot of misleading strings like these, and it's very good to fix them.
src/unix/lwt_bytes.ml
Outdated
Collaborator
There was a problem hiding this comment.
Should this be "Lwt_bytes.blit_from_bytes"?
src/unix/lwt_bytes.ml
Outdated
Collaborator
There was a problem hiding this comment.
...and this "Lwt_bytes.blit_to_bytes"?
Contributor
Author
There was a problem hiding this comment.
and yes
see new commit
Collaborator
|
Thanks again! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.