Lwt_list: More tests.#392
Conversation
|
One other thing, can we translate the comment in test_exception into English? |
|
Here's the translation Tbh, I'm not sure this comment has any purpose. |
|
Thanks! It seems that comment can be deleted indeed. Could you split the commit into two, one that does whitespace and renamings, and another that adds the new tests? The reason is that it will make it both easier to review now (not that important, but nice), and also easier to read the history later (more important). For the lines that changed only whitespace, a person reading the blame will see something like "whitespace and renamings" and be able to immediately recognize the commit doesn't change logic, and click past it to the previous blame. |
|
@aantron I've split the changes into three commits, please take another look. |
|
Great, thank you! This brings the coverage of We also probably need to test everything against exceptions raised by |
|
The follow-on is #395. Also, cherry-picked these commits onto |
Also formatted the code using ocp-indent and renamed the tests so they
have descriptive names instead of just numbers.