Conversation
aantron
left a comment
There was a problem hiding this comment.
Thanks, modulo two nits it looks good. One nit is inline.
For the Win32 failure (MinGW), you should add a LWT_NOT_AVAILABLEx macro to this ugly list in lwt_unix_windows.h. The number refers to the number of arguments to the C function, so I believe in this case that would be LWT_NOT_AVAILABLE1(unix_getcwd_job).
I'll have to add a note about doing this for Win32 to that future C calls guide.
src/unix/lwt_unix_unix.h
Outdated
There was a problem hiding this comment.
This function should take an argument value unit (see elsewhere in the file). Technically, it's not necessary, since this is C and we don't try to use the argument, but OCaml is passing that argument to this function when it calls it (and its value is zero, though it may be encoded as 1, I forgot how () is actually encoded).
src/unix/lwt_unix_windows.h
Outdated
There was a problem hiding this comment.
Should be unix_getcwd_job, I believe.
|
Canceling the Travis macOS build, so it doesn't hold up the next build – so ignore the upcoming Travis "failure" :) |
00f5a75 to
b63e0e5
Compare
|
Wow, AppVeyor hates us today. The build sometimes hangs, and we haven't had time to debug it. It's not because of this PR. I restarted the build. |
|
😓 thanks! |
A clean history for the same commits as the previous PR.
Fixes #342