lwt.unix: add Lwt_unix.send_msgto that takes a destination address
#805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to send IO Vectors over unconnected sockets (e.g. UDP)
raphael-proust
requested changes
Sep 12, 2020
Collaborator
raphael-proust
left a comment
There was a problem hiding this comment.
This also needs a test. There's already one for send_msg in test/unix/test_lwt_bytes.ml so it'd just be a case of adapting it.
Collaborator
|
It's good as far as I can tell. Unfortunately this is not very far because of my unfamiliarity with the C bindings. Anyone else can give this a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to send IO Vectors over unconnected sockets (e.g. UDP).