Handle an optional IOV_MAX #801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is used internally to implement system_limit, which already returns int option. There is no behaviour change.
IOV_MAX is optional in POSIX [1], so it is not defined if the OS does not specify an actual limit. Hence, make lwt_unix_iov_max simply return None, as it is handled already by the callers. [1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html
aantron
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOV_MAXis optional in POSIX [1], so it is not defined if the OS does not specify an actual limit. Considering thatLwt_unix.IO_vectors.system_limitalready returnsint option, then make the C stub returnint optiondirectly based on whetherIOV_MAXis defined.[1] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html
Potentially now
lwt_unix_iov_maxcould be built also on Windows, removing the if insystem_limit; however I don't have a Windows setup to test this, and it can be deferred as a later change anyway.