-
Notifications
You must be signed in to change notification settings - Fork 5
fix(Dockerfile): don't expose environment variables #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this avoids exposing secrets in Docker containers
otherwise nicegui fails to run and the `odtp dashboard` command does not work
that way the docker-compose file can be filled with the secrets on docker compose up the configurations can be checked with `docker compose config`
provide two example `.env` files: one for local setup and one for the docker compose setup
the data that is loaded there is outdated
use mongodb function for the setup and remove mongodb class
these functions are not used any more
d69d380 to
b76ee55
Compare
|
Hello @sabinem, Most changes looks good to me. What's the reason for the name changing in https://github.com/search?q=docker-compose.yml&type=repositories. |
igonre .env.compose, ignoring odtpDB.json is no longer needed
since it has been replaced by compose.yml
5cbc748 to
f2fc53e
Compare
|
@caviri I have removed the |
in order to combine compose.yml with environment variables a `.env` is needed. See here for an explanation: https://stackoverflow.com/questions/48495663/docker-compose-env-file-not-working
|
@caviri I followed up most of your suggestions, please dev review again:
|
This PR fixes the docker-compose setup:
.envandcompose.ymlare separated, see here for the general recipe: Ways to set environment variables with Composesecrets are loaded from the environment variables in order to not expose them in the docker containers: therefore dotenv is switched from using
dotenv_valuestoload_dotenv