Secrets compatibility #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
sabinem
approved these changes
Apr 18, 2024
compose.yml
Outdated
|
|
||
| networks: | ||
| odtp-network: | ||
| driver: bridge |
Contributor
There was a problem hiding this comment.
nitpick: Can you please add a blank line at the end of the file
2 tasks
29c7814 to
403470d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some components require the loading of secrets as env. variables. If we use parameters, the value will get stored in the database. To avoid this. Here I implemented a method to load secrets when running
odtp execution run .... These secrets are parsed using a similar method to the regular parameters and then they are loaded.I tested this in
odtp-travel-data-dashboardwhich requires a token and username to access to private repositories in github.Next, I will test it in the
odtp-sql-to-filecomponent.P.S. I also added a correction to the
compose.ymlas it wasn't sending the proper network to the child components.