Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cli enhacement #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
caviri merged 2 commits into from
Apr 22, 2024
Merged

Cli enhacement #94

caviri merged 2 commits into from
Apr 22, 2024

Conversation

@caviri
Copy link
Member

@caviri caviri commented Apr 19, 2024

I added another experimental feature for the CLI. Now, the document IDs are not mandatory to run the executions. But we can use digital twins/executions names, and components tags (component:version i.e. odtp-eqasim:0.2.1 ) to build the pipeline in the CLI.

#93

This opens the door to creating bash scripts to run the whole execution, making it easier to perform full pipeline tests and share executions. Like this:

odtp new user-entry \
--name Ai-1234 \
--email [email protected] \
--github ai 

odtp new digital-twin-entry \
--user-email [email protected]  \
--name dt-example

odtp new execution-entry \
--name execution-eqasim-test \
--digital-twin-name dt-example \
--component-tags odtp-eqasim-dataloader:0.3.1,odtp-eqasim:0.4.2,odtp-eqasim-matsim:0.1.2,odtp-travel-data-dashboard:0.1.1 \
--parameter-files pa1,pa2,pa3,pa4 \
--ports ,,,8502:8501

odtp execution prepare --execution-name execution-eqasim-test --project-path corsica-dt

odtp execution run --execution-name execution-eqasim-test --secrets-files ,,,se4 --project-path corsica-dt

P.S. If you know a better name for this (component:version) construct, please let me know. I got inspired by how you can pull the images in docker

@sabinem sabinem changed the base branch from main to develop April 22, 2024 09:26
@sabinem
Copy link
Contributor

sabinem commented Apr 22, 2024

@carlos: Let's merge this into develop instead of main. (I just did this: then the CHANGELOG needs to be adapted. I think we should bundle this with some other PRs, such as #97 and a PR to generally only add components by their versions to the Mongo DB. Otherwise we might get a mess in the mongodb. We should then aim to release all these PRs together in a next release this week. Would that work for you?

Also this branch needs a rebase before the dev review: so that the changes are visible.

@caviri caviri merged commit 174bb4d into develop Apr 22, 2024
@caviri caviri deleted the CLI-enhacement branch April 22, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@caviri @sabinem