Component version instead of commits #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c8266b8 to
f3acfe5
Compare
cd863a3 to
ba4ff8a
Compare
component versions in ODTP should correspond to the tags on their github repos. Therefore only version names are taken, where the tags can be found on github. Additionally the url is taken from github for a component. This avoids that the component will be registered multiple time datetime.utcnow() is deprecated and is been replaced by datetime.now(timezone.utc) make settings safer by putting it into a try except block and use `eval` instead of `bool` to evaluate boolean settings
ba4ff8a to
a7b923f
Compare
Contributor
There was a problem hiding this comment.
It looks like the ODTP_DASHBOARD_RELOAD variable isn't being reused elsewhere in the code.
Contributor
Author
There was a problem hiding this comment.
@sabrinaossey: good catch. I have added a commit, so the setting will be used again in the dashboard run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
datetime.utcnow() is deprecatedand is been replaced bydatetime.now(timezone.utc)evalmust be used instead ofbooland try except block is added for making settings errors better understandable