feat(dashboard run page): simplfy project folder creation #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
project forlder name is derived from the execution title on folder create there is always a new folder created in the users workspace so that the user will be able to easily run the selected execution
Member
|
Good, I like the slung python package :) We should have another PR in which we discuss the project folder organization and the name convention, cause it can happen that both dt/executions contains the same name which can leads to conflicts. A quick solution for this can be the slug + the mongoDB URI. |
caviri
approved these changes
Jun 24, 2024
Contributor
Author
|
@caviri Thanks and agreed, but let's discuss the folder name in another PR. I can see the potential for conflicts and propose something in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
project forlder name is derived from the execution title on folder create there is always a new folder created in the users workspace so that the user will be able to easily run the selected execution