feat(execution-timestamps) #159
Conversation
sabinem
left a comment
There was a problem hiding this comment.
fix I think to be consistent we should add the timestamps also on the steps. They also have a start_timestamp and end_timestamp.
suggestion:
Additionally the steps have a timestamp field whereas the execution do not. I would add would add a timestamp field also on the execution and set it to the time when the execution was created.
suggestion
|
Hello @sabinem, the steps have an ending timestamp implemented. It's coming from the component itself. I'll expand this to I agreed on your suggestion to include a creation timestamp. Follow what we are using in other documents, we can add: Would this works? |
|
@caviri yes sounds good to me: watch out when renaming the timestamp field on where in the code it is used. |
|
Hi @sabinem, here you have the PR adding the P.S. I still need to test this. |
…rt/ending from creation.
|
Hello @sabinem, I added the timestamps on the orchestrator. This is only valid when the steps are running ephemeral components. |
Added real timestamp for executions.