Conversation
659b1ce to
52a147e
Compare
added 5 commits
February 6, 2024 11:23
BREAKING CHANGE: schema change for components and versions: * components store the repoLink and for their versions the `versions` property is added, that contains a list of versions * versions get a `commitHash` property and `version` is renamed to `odtp_version` PREPARE FOR GUI: move logic into db functions so that the logic is captured there and can be used by both gui and cli these functions are added in a new folder `mongodb` the db access uses the `with` statements for the mongo client because otherwise it is not possible to close the mongo db connection Some new db functions and cli commands are added as they will be useful for the gui the old db functions are kept so far, so that all other code will still run: a clean up of the previous db handling will be done at a later step fix(mongodb/db.py): remove decorator import
the adaptation is not finished and tested yet adaptation to the mongo db schema changes in component and version
the session state is stored in the directory `.nicegui`
cb1259a to
f9610a9
Compare
added 2 commits
February 7, 2024 06:08
component and version are always added together, so this should also be done when entering them to the mongodb add cli command to delete collections adapt cli command to add component and version
nicegui offeres a better user experience with partial page update instead of full page loads. Therefore it was decided to switch from streamlit to nicegui for the UI add command to start nicegui dashboard
f9610a9 to
e60100f
Compare
added 7 commits
February 7, 2024 06:12
I had trouble to install the dev tools such as `black` with pdm Therefore and because poetry is more standard I would stay with poetry for now
an a mac with Apple Chip you need to change the default shell before installing
the changelog should not be part of the Readme as the Readme relates to the current state of the repo the changelog is also an important document that should be easy to find in the project folder
added 2 commits
February 7, 2024 10:42
The UI will be rebuild with Nicegui and replace the Streamlit UI, but the transition is not complete yet
caviri
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Goals:
Reimplement the CLI as GUI
Choices:
Nicegui replaces Streamlit
Nicegui is used and will replace Streamlit
odtp/dashboardMove DB logic from CLI to DB functions
odtp/mongodb/db.pyodtp/db.pyhave been kept so far and will only be removed after all adaptations have been completedodtp/setup.pyare not fully adapted yetSchema change in Mongo DB
componentsgot new properties:repoLink: url to the git repositoryversions: list of the dependentversion_ids of theirversionsversionsproperties also changed:commitHash: contains commit that was used to build the docker imagerepoLink: was remove as it is now part of thecomponentsversionwas renamed toodtp_versionStatus
Nicegui Dashboard
Work in progress:
Done:
In Work:
Open Questions: