Mark ruby bindings as ractor safe #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1283 +/- ##
==========================================
- Coverage 51.10% 51.07% -0.04%
==========================================
Files 45 45
Lines 18259 18260 +1
==========================================
- Hits 9332 9326 -6
- Misses 8927 8934 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oetiker
previously approved these changes
Mar 27, 2025
|
@LevitatingBusinessMan Please update the |
c72578
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My other PR isn't merged yet but I would also like for you to look at this one.
Ruby has a new method for concurrency called Ractors.
For C bindings to be used inside a Ractor they need to be marked Ractor-safe:
https://docs.ruby-lang.org/en/master/extension_rdoc.html#label-Appendix+F.+Ractor+support
I think all of the methods present in the bindings are inherently thread safe.
By marking them Ractor-safe ruby programs can generate graphs concurrently.
See also ruby/ruby#3824 for more information concerning this method.