m4/acinclude.m4: write ETH_P_ALL check as function body, not function definition
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on definition - Fixes ofalk#109 - `AC_TRY_COMPILE` macro's second argument is a function body, not a complete function definition. Placing a complete function defintion here results in m4 generating a malformed test program with a function definition inside another function defintion, which would break the check to make it always evaluate false whenever Clang is used, since Clang rejects programs that use GCC-only extensions like function definition inside another function definition.
- Necessary to apply the `ETH_P_ALL` function body change to the `configure` script, in order to fix ofalk#109 - `aclocal --force` run - `autoreconf -fi` run - `autom4te.cache`, which appeared afterward, added to `.gitignore`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes building using Autotools + Clang causes PF_PACKET support detection to fail #109
AC_TRY_COMPILEmacro's second argument is a function body, not acomplete function definition. Placing a complete function defintion
here results in m4 generating a malformed test program with a function
definition inside another function defintion, which would break the
check to make it always evaluate false whenever Clang is used, since
Clang rejects programs that use GCC-only extensions like function
definition inside another function definition.
Autotools files regenerated, necessary to apply the
ETH_P_ALLfunction body change to theconfigurescriptaclocal --forcerunautoreconf -firunautom4te.cache, which appeared afterward, added to.gitignore