Check the number of required path params #360
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, mismatch of path params at registration like
causes undefined behavior, actually ( Ohkami trusted users TOO much that they never write such codes ) .
This PR:
n_paramstoIntoHandlerand store it inHandlerSet.base::Router'sroutesto holdHashMap<RouteSegments, TupleMap<Method, HandlerMeta>>, hereHandlerMetastoresn_paramsbase::Router::finalizeto check that each handler'sn_paramsdoesn't exceeds the number of param segments of correspondedRouteSegments. if exceeds, safely panic with friendly message.The
n_paramss exist only in preparing step, and the check is executed before starting serving. So this PR does NOT affect the performance.