Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Dx(worker): copy var binding doc comments to associated consts #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: v0.23.2
merged 3 commits into from
Feb 21, 2025
Merged

Dx(worker): copy var binding doc comments to associated consts #394

merged 3 commits into from
Feb 21, 2025

Conversation

@kanarus
Copy link
Member

@kanarus kanarus commented Feb 21, 2025

Before, in manual binding mode of #[bindings], doc comments for variable bindings like

#[bindings]
struct Bindings {
    /// this is a sample variable binding
    MY_VARIABLE: bindings::Var,
}

are not shown only for the fields, not in associated consts corresponded to them. This PR improves this DX by copying the doc comments if any to each associated consts.

@kanarus kanarus merged commit b6dde53 into v0.23.2 Feb 21, 2025
9 checks passed
@kanarus kanarus deleted the DX/worker/bindings branch February 21, 2025 13:09
@kanarus kanarus linked an issue Feb 21, 2025 that may be closed by this pull request
DX(worker): copy doc comment for a Var binding to associated const #388
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DX(worker): copy doc comment for a Var binding to associated const

1 participant

@kanarus