Adash better embeddings #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zoheb-Malik
approved these changes
Nov 18, 2024
Collaborator
Zoheb-Malik
left a comment
There was a problem hiding this comment.
Overall everything looks good to me, maybe the new commands and the order of the usage of the commands and how OI can be used in CLI needs to be more clearly documented/updated in the README to reflect any changes you made, but otherwise happy. You could make an updated README as a separate PR. Some of my old documentation changes may not even be relevant or correct anymore, so it would be ideal for you to check and change accordingly. Again my apologies for getting back to this so late!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log
Contains bug fixes and refactors the parsing service into parsing and embedding service. Added additional config option to enable embedding in a project.