Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jLopezbarb
Copy link
Contributor

Modified the command used to reset the syncthing database to include the "debug" flag and adjust the argument order for improved functionality. This change enhances the command's clarity and ensures proper execution during the reset process.

Fixes #PROD-424

Signed-off-by: Javier Lopez [email protected]

How to validate

  1. Wait until fix: update command for resetting syncthing database supervisor#21 is merged or build it and add OKTETO_BIN env var
  2. Run okteto up
  3. Exit and run okteto up --reset

CLI Quality Reminders 🔧

For both authors and reviewers:

  • Scrutinize for potential regressions
  • Ensure key automated tests are in place
  • Build the CLI and test using the validation steps
  • Assess Developer Experience impact (log messages, performances, etc)
  • If too broad, consider breaking into smaller PRs
  • Adhere to our code style and code review guidelines

Modified the command used to reset the syncthing database to include the "debug" flag and adjust the argument order for improved functionality. This change enhances the command's clarity and ensures proper execution during the reset process.

Signed-off-by: Javier Lopez <[email protected]>
@jLopezbarb jLopezbarb requested a review from a team as a code owner November 11, 2025 11:26
@jLopezbarb jLopezbarb added release/bug-fix backport release-3.13 Backport this PR to CLI versions 3.13 backport release-3.12 Backport this PR to CLI versions 3.12 labels Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.41%. Comparing base (93bd174) to head (6f03745).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4818   +/-   ##
=======================================
  Coverage   48.41%   48.41%           
=======================================
  Files         369      369           
  Lines       30581    30581           
=======================================
  Hits        14806    14806           
  Misses      14591    14591           
  Partials     1184     1184           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jLopezbarb jLopezbarb merged commit 09de91d into master Nov 11, 2025
27 of 29 checks passed
@jLopezbarb jLopezbarb deleted the jlo/fix-reset-syncthing-db branch November 11, 2025 13:24
github-actions bot pushed a commit that referenced this pull request Nov 11, 2025
Modified the command used to reset the syncthing database to include the "debug" flag and adjust the argument order for improved functionality. This change enhances the command's clarity and ensures proper execution during the reset process.

Signed-off-by: Javier Lopez <[email protected]>
(cherry picked from commit 09de91d)
@github-actions
Copy link
Contributor

The backport to release-3.12 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-3.12 release-3.12
# Navigate to the new working tree
cd .worktrees/backport-release-3.12
# Create a new branch
git switch --create backport-4818-to-release-3.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 09de91d3bded066bb6195a8e3b965c584854f1c2
# Push it to GitHub
git push --set-upstream origin backport-4818-to-release-3.12
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-3.12

Then, create a pull request where the base branch is release-3.12 and the compare/head branch is backport-4818-to-release-3.12.

jLopezbarb added a commit that referenced this pull request Nov 11, 2025
Modified the command used to reset the syncthing database to include the "debug" flag and adjust the argument order for improved functionality. This change enhances the command's clarity and ensures proper execution during the reset process.

Signed-off-by: Javier Lopez <[email protected]>
(cherry picked from commit 09de91d)
Signed-off-by: Javier Lopez <[email protected]>
jLopezbarb added a commit that referenced this pull request Nov 11, 2025
Modified the command used to reset the syncthing database to include the "debug" flag and adjust the argument order for improved functionality. This change enhances the command's clarity and ensures proper execution during the reset process.


(cherry picked from commit 09de91d)

Signed-off-by: Javier Lopez <[email protected]>
Co-authored-by: Javier López Barba <[email protected]>
jLopezbarb added a commit that referenced this pull request Nov 11, 2025
Modified the command used to reset the syncthing database to include the "debug" flag and adjust the argument order for improved functionality. This change enhances the command's clarity and ensures proper execution during the reset process.


(cherry picked from commit 09de91d)

Signed-off-by: Javier Lopez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport release-3.12 Backport this PR to CLI versions 3.12 backport release-3.13 Backport this PR to CLI versions 3.13 release/bug-fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants