Thanks to the example, i mostly made it work - it's no as easy as i'd like, but perfectly functional. However, when trying to use it from an async context (specifically, iced-futures), i'm getting errors like these:

error: future cannot be sent between threads safely
   --> src/instance.rs:106:17
    |
106 |                 iced::Command::perform(perform_update(self.clone()), Message::Updated)
    |                 ^^^^^^^^^^^^^^^^^^^^^^ future returned by `perform_update` is not `Send`
    | 
   ::: /home/flo/.cargo/registry/src/github.com-1ecc6299db9ec823/iced_futures-0.1.2/src/command.rs:32:22
    |
32  |         future: impl Future<Output = T> + 'static + Send,
    |                      ------------------ required by this bound in `iced_futures::command::Command::<T>::perform`
    |
    = help: the trait `std::marker::Send` is not implemented for `dyn bitar::reader::Reader`
note: future is not `Send` as this value is used across an await
   --> src/update.rs:77:34
    |
58  |       let archive = Archive::try_init(&mut reader).await?;
    |                                       -----------        - `&mut reader` is later dropped here
    |                                       |
    |                                       has type `&mut dyn bitar::reader::Reader`
...
77  |       let total_read_from_remote = clone_from_archive(
    |  __________________________________^
78  | |         &CloneOptions::default(),
79  | |         &mut reader,
80  | |         &archive,
...   |
83  | |     )
84  | |     .await?;
    | |__________^ await occurs here, with `&mut reader` maybe used later

If you don't need any kind of feedback, one can use this terrible workaround:
https://github.com/EndlessSkyCommunity/ESLauncher2/blob/d45b4223f3c387874a8d34d06bdc6d80030cb61b/src/instance.rs#L213-L222
But now i kinda need this function to return things, so i'm back to square one.

Is this something that can be fixed in bitar, e.g. by implementing Send for Reader and CloneOutput? (and possibly more? those are the two i get errors for)

Use as library #13

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions