This repository was archived by the owner on Jul 31, 2024. It is now read-only.
Component registration updated #268
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 29, 2024 17:15
|
NikhilVerma
suggested changes
Apr 30, 2024
|
|
||
| import { ConfigUtil } from "@ollion/flow-core-config"; | ||
| import { version } from "../package.json"; | ||
| import { LitElement } from "lit"; |
Contributor
There was a problem hiding this comment.
I think barrel files are not handled when doing tree shaking https://vitejs.dev/guide/performance#avoid-barrel-files
We should try enabling sideEffects option in package.json and check if Vite can tree shake unused components - https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free
Contributor
There was a problem hiding this comment.
We can try publishing a beta version, and check if vite handles this correctly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for raising a PR
Describe your PR
@ollion/flow-core
[3.0.0] - 2024-04-29
Major/Breaking Changes
@ollion/flow-code-editor
[2.0.0] - 2024-04-20
Major/Breaking Changes
@ollion/flow-form-builder
[3.0.0] - 2024-04-29
Major/Breaking Changes
@ollion/flow-lineage
[4.0.0] - 2024-04-29
Major/Breaking Changes
@ollion/flow-log
[3.0.0] - 2024-04-29
Major/Breaking Changes
@ollion/flow-md-editor
[3.0.0] - 2024-04-29
Major/Breaking Changes
@ollion/flow-table
[3.0.0] - 2024-04-29
Major/Breaking Changes