-
Notifications
You must be signed in to change notification settings - Fork 28
Replace mailing lists and QA with forum.image.sc and Zenodo #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sbesson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The POM decisions will likely be applicable to https://github.com/ome/bioformats.
I agree with the removal of the obsolete mailingLists element. There is no real alternative in the Maven model. A field worth updating might be issueManagement to point at https://github.com/ome/ome-model/issues as this should be the primary location where I would expect developer interaction.
On CONTRIBUTING.md, the content was largely extracted from the original Bio-Formats repository but a lot of its content is irrelevant (develop branch, Bio-Formats documentation). In the absence of a generic CONTRIBUTING page under https://github.com/ome/.github, I wonder whether https://ome-contributing.readthedocs.io/en/latest/general.html is the current best starting point for a contributor to any OME repository as it links to various relevant resources? /cc @jburel @joshmoore
pom.xml
Outdated
| <developer> | ||
| <name>The OME Team</name> | ||
| <email>[email protected]</email> | ||
| <url>https://forum.image.sc/g/ome</url> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be https://www.openmicroscopy.org/teams/?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 9f31838. My initial thinking there was to keep the spirit of the email attribute, which is how to contact us directly - but you're right that the official team page makes more sense here.
joshmoore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
Is it the beginning of a general review? |
|
I didn't have a general review of QA/mailing list references planned, this PR was just part of the issue cleanup in this repo. We can plan a more thorough review of other repos separately, at a time that's convenient for dividing up work. |
Fixes #107.
The changes to
CONTRIBUTING.mdshould be straightforward, but I'm open to other ways to updatepom.xml. There doesn't appear to be an equivalent tomailingListfor specifying a forum, so I opted to just remove themailingListsblock to minimize confusion. If keeping the archive links only or doing something else is preferable, happy to do that instead.