fix potential lightgallery markup conflict#1056
Merged
zerocrates merged 1 commit intoomeka:masterfrom Jun 12, 2025
Merged
Conversation
Member
|
I'm not sure we confirmed a Big Picture issue with this, but I think we did see that Foundation would have one. Those aren't big insurmountable problems though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where using a plugin filter to add support for Omeka's standard LightGallery cannot work in themes that wrap their default media markup in an
#itemfilescontainer (this is the case for the default templates – and thus Seasons – as well as Rhythm, Minimalist, Freedom, Thanks Roy, and Emiglio). This also fixes a potential validation issue since those themes would also have a duplicate#itemfilesdiv. All that's changed here is that the default markup now uses a more specific id that is less likely to have conflicts. This minor change does not appear to manifest in any CSS selector issues with themes that already use LightGallery by default (Center Row, The Daily).Update
There actually is an issue with the Big Picture theme that would need to be addressed in a future update.