refactor: use Queryset.defer() in XFormViewSet#2996
Merged
kelvin-muchiri merged 2 commits intomainfrom Jan 16, 2026
Merged
Conversation
4b2342b to
66b1658
Compare
Use Queryset.defer() in XFormViewSet since the fields to be deferred are fewer than the fields to be loaded. Also takes into account that new fields can be added to the serializer and forgotten to be added in Queryset.only() Use exclude all by default policy for XForm's serializer fields. Explicitly define what fields should be exposed
66b1658 to
73f9b3c
Compare
ukanga
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes/Features implemented
Queryset.defer()inXFormViewSetsince the fields to be deferred are fewer than the fields to be loaded. Makes the code neater and eliminates N+1 queries arising from a new field being added in the serializer and failing to be added in the viewset'sQueryset.only()Steps taken to verify this change does what is intended
Side effects of implementing this change
None
Before submitting this PR for review, please make sure you have:
Closes #