Fix slab size when resetting mutable storable in OrderedMap#337
Merged
fxamacker merged 1 commit intofxamacker/fix-slab-size-when-resetting-same-storable-in-arrayfrom Sep 12, 2023
Conversation
Also extracted map data slab prefix computation to a new function.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## fxamacker/fix-slab-size-when-resetting-same-storable-in-array #337 +/- ##
=================================================================================================
+ Coverage 65.32% 65.36% +0.04%
=================================================================================================
Files 14 14
Lines 8773 8784 +11
=================================================================================================
+ Hits 5731 5742 +11
Misses 2325 2325
Partials 717 717
☔ View full report in Codecov by Sentry. |
ramtinms
approved these changes
Sep 5, 2023
f4110e8
into
fxamacker/fix-slab-size-when-resetting-same-storable-in-array
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #292 #335
Changes
Recompute slab size by adding all element sizes instead of using the size diff of old and new element because
oldElemcan be the same storable when the same value is reset andoldElem.ByteSize()can equalstorable.ByteSize().Given this, size diff of the old and new element can be 0 even when its actual size changed.
Also extracted map data slab prefix computation to a new function.
This is prep work for atree inlining to prevent a bug from surfacing.
mainbranchFiles changedin the Github PR explorer