Add inclusion fee for scheduled transactions #548
Conversation
| let storageFee = FlowStorageFees.storageCapacityToFlow(dataSizeMB) | ||
|
|
||
| return scaledExecutionFee + storageFee | ||
| // Add inclusion Flow fee for scheduled transactions |
There was a problem hiding this comment.
Wouldn't this be better to just include in the FlowFees.computeFees call in calculateFees(). We can just use a higher inclusion effort there
There was a problem hiding this comment.
Yeah but that wouldn't really be a base fee since it would depend on the priority. This felt to me more natural to think, like X is always minimum what you have to pay (no matter priority). But I'm open to change if you feel strongly against. How do you feel about the amount btw?
There was a problem hiding this comment.
I guess I just don't understand the purpose of this. Because the minimum execution effort is 100, there is always a minimum fee, so this feel unnecessary
There was a problem hiding this comment.
Check comment from Dete asking for this and his explanation. https://gololicic.slack.com/archives/C08LL92U3BK/p1760473092311309
There was a problem hiding this comment.
Yes, I saw it. We can include it in the next upgrade
|
We are going to hold off on including this for now. Need to get the other upgrades in |
|
Including this in #555. closing this PR |
Add inclusion fee for scheduled transactions in order to incentivize scheduling single transaction vs multiple.