Just reviewed the diff, this looks great.

Encountered a weird dependencies thing:

• went to run tests, did not have responses installed
• installed dependencies with pip install pyproject.toml[dev], ran tests, still did not have responses installed
• triple checked pyproject.toml lists responses under, dev - yup:

[project.optional-dependencies]
dev = [
    "pytest",
    "responses",
    "twine",
    "vcrpy"
]

• confirmed responses was not installed, tried a couple other pip install invocations, nothing installed responses.
• manually ran pip install responses - it installed stateing the usual bits about already satisfied requirements.
• ran pytest tests/test_all.py, ran pytest tests/test_sync.py -- tests pass.

I've got no clue what was going on there, and I never got a warning about conflicts blocking something. Have I maybe misunderstood how to invoke pip to install those dev requirements?

The correct command is pip install ".[dev]" or if installing from PyPI: pip install "beiwe-forest[dev]"

OK - question about these tests using responses:

• Mano doesn't have the ability to do anything with a partially downloaded zip file - that's a feature I intend to work on.
  • (This zip file is not compressed, it is just a container, so the bytes of files are all there up to the point the connection breaks)
• So, does responses have a way to inject a network error in a test?
  • currently I think the way is to yield some bytes and then raise an error

The correct command is pip install ".[dev]" or if installing from PyPI: pip install "beiwe-forest[dev]"

yup that was it, thanks.

Ok looks like there are still vcr tests in test_all.py.
If scope of this pull request is just to remove the pinned urllib I'm happy with it and can hit approve, if it includes converting all vcr tests to responses tests .... I guess carry on! Lemme know.

OK - question about these tests using responses:

* Mano doesn't have the ability to do anything with a partially downloaded zip file - that's a feature I intend to work on.
  
  * (This zip file is not compressed, it is just a container, so the bytes of files are all there up to the point the connection breaks)

* So, does responses have a way to inject a network error in a test?
  
  * currently I think the way is to yield some bytes and then raise an error

How's this: ac12f0b

Ok looks like there are still vcr tests in test_all.py. If scope of this pull request is just to remove the pinned urllib I'm happy with it and can hit approve, if it includes converting all vcr tests to responses tests .... I guess carry on! Lemme know.

Yes, the scope here is just to deal with urllib3. If we are happy with this approach the next PR will replace vcrpy with responses in a similar manner.