Mark VERSION_NUMBER as final for 1.13.1 release
#4876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: p-wysocki <[email protected]>
Signed-off-by: Chun-Wei Chen <[email protected]>
jcwchen
reviewed
Feb 14, 2023
Member
jcwchen
left a comment
There was a problem hiding this comment.
Please fix the lint error here:
===> check flake8...
onnx/reference/ops/op_string_normalizer.py:89:17: B028 No explicit stacklevel keyword argument found. The warn method from the warnings module uses a stacklevel of 1 by default. This will only show a stack trace for the line on which the warn method is called. It is therefore recommended to use a stacklevel of 2 or greater to provide more information to the user.
It was not caught previously, because the lint CI has been updated recently. Thanks!
Signed-off-by: p-wysocki <[email protected]>
jcwchen
approved these changes
Feb 21, 2023
Member
jcwchen
left a comment
There was a problem hiding this comment.
I think we can finalize this release since there isn't any regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mark the
VERSION_NUMBERas the final 1.13.1 release. Please do not merge until agreed that we're ready to push to PyPI.