Support JSON as a serialization target #5523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
d3025f2 to
eb32c2c
Compare
jcwchen
reviewed
Aug 24, 2023
|
I don't think there is one, but it's also not realistic to have big models in json because the text representation is less efficient. |
|
onnxjson? onnx.json? onnx.json is easier for editors I can add both json and onnxjson. |
justinchuby
commented
Aug 24, 2023
Signed-off-by: Justin Chu <[email protected]>
liqunfu
approved these changes
Aug 24, 2023
Internally protobuf still use int instead of sizes_t as array length type. |
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description
Create serializers to the `json` format and register the `json` and
`onnxjson` extensions to it.
```python
import onnx
model = onnx.load_model("onnx/backend/test/data/light/light_resnet50.onnx")
onnx.save_model(model, "resnet50.json")
```
yields
```json
{
"ir_version": "3",
"producer_name": "onnx-caffe2",
"producer_version": "",
"domain": "",
"model_version": "0",
"doc_string": "",
"graph": {
"node": [
{
"input": [
"gpu_0/conv1_w_0__SHAPE"
],
"output": [
"gpu_0/conv1_w_0"
],
"op_type": "ConstantOfShape",
"attribute": [
{
"name": "value",
"t": {
"dims": [
"1"
],
"data_type": 1,
"float_data": [
0.02
],
"name": ""
},
"type": "TENSOR"
}
]
},
{
"input": [
"gpu_0/pred_b_0__SHAPE"
],
"output": [
"gpu_0/pred_b_0"
],
"op_type": "ConstantOfShape",
"attribute": [
{
"name": "value",
"t": {
"dims": [
"1"
],
"data_type": 1,
"float_data": [
0.02
],
"name": ""
},
"type": "TENSOR"
}
]
},
{
"input": [
"gpu_0/pred_w_0__SHAPE"
],
"output": [
"gpu_0/pred_w_0"
],
"op_type": "ConstantOfShape",
"attribute": [
{
"name": "value",
"t": {
"dims": [
"1"
],
"data_type": 1,
"float_data": [
0.02
],
"name": ""
},
"type": "TENSOR"
}
]
},
...
```
### Motivation and Context
A more familiar text representation for free from protobuf using
https://googleapis.dev/python/protobuf/latest/google/protobuf/json_format.html
---------
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Corwin Joy <[email protected]>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description
Create serializers to the `json` format and register the `json` and
`onnxjson` extensions to it.
```python
import onnx
model = onnx.load_model("onnx/backend/test/data/light/light_resnet50.onnx")
onnx.save_model(model, "resnet50.json")
```
yields
```json
{
"ir_version": "3",
"producer_name": "onnx-caffe2",
"producer_version": "",
"domain": "",
"model_version": "0",
"doc_string": "",
"graph": {
"node": [
{
"input": [
"gpu_0/conv1_w_0__SHAPE"
],
"output": [
"gpu_0/conv1_w_0"
],
"op_type": "ConstantOfShape",
"attribute": [
{
"name": "value",
"t": {
"dims": [
"1"
],
"data_type": 1,
"float_data": [
0.02
],
"name": ""
},
"type": "TENSOR"
}
]
},
{
"input": [
"gpu_0/pred_b_0__SHAPE"
],
"output": [
"gpu_0/pred_b_0"
],
"op_type": "ConstantOfShape",
"attribute": [
{
"name": "value",
"t": {
"dims": [
"1"
],
"data_type": 1,
"float_data": [
0.02
],
"name": ""
},
"type": "TENSOR"
}
]
},
{
"input": [
"gpu_0/pred_w_0__SHAPE"
],
"output": [
"gpu_0/pred_w_0"
],
"op_type": "ConstantOfShape",
"attribute": [
{
"name": "value",
"t": {
"dims": [
"1"
],
"data_type": 1,
"float_data": [
0.02
],
"name": ""
},
"type": "TENSOR"
}
]
},
...
```
### Motivation and Context
A more familiar text representation for free from protobuf using
https://googleapis.dev/python/protobuf/latest/google/protobuf/json_format.html
---------
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Corwin Joy <[email protected]>
corwinjoy
pushed a commit
to corwinjoy/onnx
that referenced
this pull request
Sep 5, 2023
### Description
Create serializers to the `json` format and register the `json` and
`onnxjson` extensions to it.
```python
import onnx
model = onnx.load_model("onnx/backend/test/data/light/light_resnet50.onnx")
onnx.save_model(model, "resnet50.json")
```
yields
```json
{
"ir_version": "3",
"producer_name": "onnx-caffe2",
"producer_version": "",
"domain": "",
"model_version": "0",
"doc_string": "",
"graph": {
"node": [
{
"input": [
"gpu_0/conv1_w_0__SHAPE"
],
"output": [
"gpu_0/conv1_w_0"
],
"op_type": "ConstantOfShape",
"attribute": [
{
"name": "value",
"t": {
"dims": [
"1"
],
"data_type": 1,
"float_data": [
0.02
],
"name": ""
},
"type": "TENSOR"
}
]
},
{
"input": [
"gpu_0/pred_b_0__SHAPE"
],
"output": [
"gpu_0/pred_b_0"
],
"op_type": "ConstantOfShape",
"attribute": [
{
"name": "value",
"t": {
"dims": [
"1"
],
"data_type": 1,
"float_data": [
0.02
],
"name": ""
},
"type": "TENSOR"
}
]
},
{
"input": [
"gpu_0/pred_w_0__SHAPE"
],
"output": [
"gpu_0/pred_w_0"
],
"op_type": "ConstantOfShape",
"attribute": [
{
"name": "value",
"t": {
"dims": [
"1"
],
"data_type": 1,
"float_data": [
0.02
],
"name": ""
},
"type": "TENSOR"
}
]
},
...
```
### Motivation and Context
A more familiar text representation for free from protobuf using
https://googleapis.dev/python/protobuf/latest/google/protobuf/json_format.html
---------
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Corwin Joy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create serializers to the
jsonformat and register thejsonandonnxjsonextensions to it.yields
{ "ir_version": "3", "producer_name": "onnx-caffe2", "producer_version": "", "domain": "", "model_version": "0", "doc_string": "", "graph": { "node": [ { "input": [ "gpu_0/conv1_w_0__SHAPE" ], "output": [ "gpu_0/conv1_w_0" ], "op_type": "ConstantOfShape", "attribute": [ { "name": "value", "t": { "dims": [ "1" ], "data_type": 1, "float_data": [ 0.02 ], "name": "" }, "type": "TENSOR" } ] }, { "input": [ "gpu_0/pred_b_0__SHAPE" ], "output": [ "gpu_0/pred_b_0" ], "op_type": "ConstantOfShape", "attribute": [ { "name": "value", "t": { "dims": [ "1" ], "data_type": 1, "float_data": [ 0.02 ], "name": "" }, "type": "TENSOR" } ] }, { "input": [ "gpu_0/pred_w_0__SHAPE" ], "output": [ "gpu_0/pred_w_0" ], "op_type": "ConstantOfShape", "attribute": [ { "name": "value", "t": { "dims": [ "1" ], "data_type": 1, "float_data": [ 0.02 ], "name": "" }, "type": "TENSOR" } ] }, ...Motivation and Context
A more familiar text representation for free from protobuf using https://googleapis.dev/python/protobuf/latest/google/protobuf/json_format.html