Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix reference implementation for loops with optional number of iterations #5752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Nov 16, 2023
Merged

Fix reference implementation for loops with optional number of iterations #5752

merged 22 commits into from
Nov 16, 2023

Conversation

@xadupre
Copy link
Contributor

@xadupre xadupre commented Nov 10, 2023 •
edited
Loading

Description

Investigate issue #5750. This is caused by an optional number of iterations. This case is not covered by the backend test series.

The PR also introduces method _check_output_run. It ensures all outputs after a node execution are consistent. It also replaces every single number by an array of one element to get an consistent API.

Motivation and Context

Have better error messages or fix the implementation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 10, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 10, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 11, 2023
View reviewed changes
@xadupre xadupre marked this pull request as ready for review November 13, 2023 13:56
@xadupre xadupre requested review from a team as code owners November 13, 2023 13:56
@xadupre xadupre changed the title [WIP] Fix issue in reference implementation for loops Fix reference implementation for loops with optional number of iterations Nov 13, 2023
@codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (a5f13c4) 56.06% compared to head (328ff8a) 56.25%.

Files Patch % Lines
onnx/backend/test/runner/__init__.py 50.00% 5 Missing and 2 partials ⚠️
onnx/reference/ops/op_loop.py 66.66% 1 Missing and 1 partial ⚠️
onnx/reference/reference_evaluator.py 50.00% 1 Missing and 1 partial ⚠️
onnx/test/reference_evaluator_model_test.py 95.91% 1 Missing and 1 partial ⚠️
onnx/reference/ops/op_constant.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5752      +/-   ##
==========================================
+ Coverage   56.06%   56.25%   +0.18%     
==========================================
  Files         501      502       +1     
  Lines       29366    29495     +129     
  Branches     4404     4417      +13     
==========================================
+ Hits        16463    16591     +128     
- Misses      12091    12092       +1     
  Partials      812      812

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xadupre xadupre requested a review from justinchuby November 13, 2023 13:59
@xadupre
remove unnecessary code
92539b3 
Signed-off-by: Xavier Dupre <[email protected]>
@justinchuby justinchuby self-assigned this Nov 13, 2023
@xadupre xadupre enabled auto-merge November 13, 2023 17:03
justinchuby
justinchuby reviewed Nov 13, 2023
View reviewed changes
justinchuby
justinchuby reviewed Nov 13, 2023
View reviewed changes
@xadupre @justinchuby
Update onnx/backend/test/runner/__init__.py
cbc6569 
Co-authored-by: Justin Chu <[email protected]>
Signed-off-by: Xavier Dupré <[email protected]>
justinchuby
justinchuby reviewed Nov 13, 2023
View reviewed changes
justinchuby
justinchuby reviewed Nov 13, 2023
View reviewed changes
justinchuby
justinchuby reviewed Nov 13, 2023
View reviewed changes
justinchuby
justinchuby reviewed Nov 13, 2023
View reviewed changes
xadupre and others added 3 commits November 13, 2023 22:59
@xadupre @justinchuby
Update onnx/reference/op_run.py
8a8314d 
Co-authored-by: Justin Chu <[email protected]>
Signed-off-by: Xavier Dupré <[email protected]>
@xadupre @justinchuby
Update onnx/reference/op_run.py
77aecec 
Co-authored-by: Justin Chu <[email protected]>
Signed-off-by: Xavier Dupré <[email protected]>
@xadupre @justinchuby
Update onnx/reference/op_run.py
45dd7b4 
Co-authored-by: Justin Chu <[email protected]>
Signed-off-by: Xavier Dupré <[email protected]>
xadupre and others added 5 commits November 13, 2023 23:09
@xadupre @justinchuby
Update onnx/reference/op_run.py
67ee42c 
Co-authored-by: Justin Chu <[email protected]>
Signed-off-by: Xavier Dupré <[email protected]>
@xadupre @justinchuby
Update onnx/reference/op_run.py
9c7bee2 
Co-authored-by: Justin Chu <[email protected]>
Signed-off-by: Xavier Dupré <[email protected]>
@xadupre
add more test coverage
50e27fd 
Signed-off-by: Xavier Dupre <[email protected]>
@xadupre
fix merge conflicts
58f2d28 
Signed-off-by: Xavier Dupre <[email protected]>
@xadupre
lint
ab78b3f 
Signed-off-by: Xavier Dupre <[email protected]>
justinchuby
justinchuby reviewed Nov 15, 2023
View reviewed changes
justinchuby
justinchuby reviewed Nov 15, 2023
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 15, 2023
View reviewed changes
justinchuby
justinchuby approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments. Thanks for the fix! 🎁

@xadupre xadupre added this pull request to the merge queue Nov 16, 2023
Merged via the queue into onnx:main with commit 37b4749 Nov 16, 2023
@xadupre xadupre deleted the refbug branch November 16, 2023 11:59
linshokaku pushed a commit to linshokaku/onnx that referenced this pull request Oct 2, 2024
@xadupre @justinchuby @linshokaku
Fix reference implementation for loops with optional number of iterat…
8da4647 
…ions (onnx#5752)

### Description
Investigate issue onnx#5750. This is caused by an optional number of
iterations. This case is not covered by the backend test series.

The PR also introduces method `_check_output_run`. It ensures all
outputs after a node execution are consistent. It also replaces every
single number by an array of one element to get an consistent API.

### Motivation and Context
Have better error messages or fix the implementation.

---------

Signed-off-by: Xavier Dupre <[email protected]>
Signed-off-by: Xavier Dupré <[email protected]>
Co-authored-by: Justin Chu <[email protected]>
Signed-off-by: Linsho Kaku <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liqunfu liqunfu liqunfu approved these changes

@gramalingam gramalingam gramalingam approved these changes

@justinchuby justinchuby justinchuby approved these changes

Assignees

@justinchuby justinchuby

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xadupre @liqunfu @gramalingam @justinchuby