Support Unicode file paths when loading an ONNX file #5806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix #5761 |
justinchuby
approved these changes
Dec 14, 2023
justinchuby
reviewed
Dec 14, 2023
|
Please follow https://github.com/onnx/onnx/pull/5806/checks?check_run_id=19631633187 to signoff your commits. Thank you for your contribution! |
justinchuby
reviewed
Dec 14, 2023
justinchuby
reviewed
Dec 15, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5806 +/- ##
==========================================
+ Coverage 56.34% 56.36% +0.01%
==========================================
Files 503 503
Lines 29622 29634 +12
Branches 4434 4435 +1
==========================================
+ Hits 16690 16702 +12
Misses 12120 12120
Partials 812 812 ☔ View full report in Codecov by Sentry. |
…ces (#5795) ### Description The page showing differences between two operators is not readable in dark mode. diff2html was recently updated to fix this issue. Signed-off-by: Xavier Dupre <[email protected]> Signed-off-by: captainIT <[email protected]>
### Description -0.00001 must be converted into 0 and not negative zero which does not exist for types Float8E4M3FNUZ and Float8E5M2UZ. See microsoft/onnxruntime#18473 for further details. Signed-off-by: Xavier Dupre <[email protected]> Signed-off-by: captainIT <[email protected]>
### Description Replace "sanity" with "safety". ### Motivation and Context Inclusive terminology change Signed-off-by: Charles Volzka <[email protected]> Signed-off-by: captainIT <[email protected]>
Signed-off-by: zhangxinlin <[email protected]> Signed-off-by: captainIT <[email protected]>
Signed-off-by: zhangxinlin <[email protected]> Signed-off-by: captainIT <[email protected]>
Signed-off-by: captainIT <[email protected]>
Signed-off-by: captainIT <[email protected]>
Signed-off-by: captainIT <[email protected]>
justinchuby
reviewed
Dec 15, 2023
2、cover cjk and emoji Signed-off-by: captainIT <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Justin Chu <[email protected]>
Signed-off-by: Justin Chu <[email protected]>
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
### Description release build breaks due to #5806 filesystem not available on Mac 10.12. also need to skip 2 reference implement tests (test_qlinearmatmul_3D_int8_float16_cpu, test_qlinearmatmul_3D_int8_float32_cpu) which are failing on MacOS (#5792) ### Motivation and Context fix mac release CI --------- Signed-off-by: Liqun Fu <[email protected]> Signed-off-by: Justin Chu <[email protected]> Co-authored-by: Justin Chu <[email protected]>
wplf
pushed a commit
to wplf/onnx
that referenced
this pull request
Jan 3, 2024
### Description release build breaks due to onnx#5806 filesystem not available on Mac 10.12. also need to skip 2 reference implement tests (test_qlinearmatmul_3D_int8_float16_cpu, test_qlinearmatmul_3D_int8_float32_cpu) which are failing on MacOS (onnx#5792) ### Motivation and Context fix mac release CI --------- Signed-off-by: Liqun Fu <[email protected]> Signed-off-by: Justin Chu <[email protected]> Co-authored-by: Justin Chu <[email protected]> Signed-off-by: wplf <[email protected]>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description Support Unicode file paths when loading an ONNX file. ### Motivation and Context Fix onnx#5761 --------- Signed-off-by: Xavier Dupre <[email protected]> Signed-off-by: captainIT <[email protected]> Signed-off-by: Charles Volzka <[email protected]> Signed-off-by: zhangxinlin <[email protected]> Signed-off-by: Justin Chu <[email protected]> Co-authored-by: Xavier Dupré <[email protected]> Co-authored-by: Charles Volzka <[email protected]> Co-authored-by: zhangxinlin <[email protected]> Co-authored-by: Justin Chu <[email protected]> Signed-off-by: Linsho Kaku <[email protected]>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
### Description release build breaks due to onnx#5806 filesystem not available on Mac 10.12. also need to skip 2 reference implement tests (test_qlinearmatmul_3D_int8_float16_cpu, test_qlinearmatmul_3D_int8_float32_cpu) which are failing on MacOS (onnx#5792) ### Motivation and Context fix mac release CI --------- Signed-off-by: Liqun Fu <[email protected]> Signed-off-by: Justin Chu <[email protected]> Co-authored-by: Justin Chu <[email protected]> Signed-off-by: Linsho Kaku <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support Unicode file paths when loading an ONNX file.
Motivation and Context
Fix #5761