The latest Cmake 3.28.3 is failing with "Could NOT find Protobuf (missing: Protobuf_LIBRARIES)". Use Cmake 3.27.9 #5951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: liqunfu <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5951 +/- ##
=======================================
Coverage 56.68% 56.68%
=======================================
Files 506 506
Lines 30227 30227
Branches 4565 4565
=======================================
Hits 17133 17133
Misses 12268 12268
Partials 826 826 ☔ View full report in Codecov by Sentry. |
Signed-off-by: liqunfu <[email protected]>
Signed-off-by: liqunfu <[email protected]>
yes it is - cmake of desired version is installed with the fix. |
gramalingam
reviewed
Feb 22, 2024
gramalingam
approved these changes
Feb 22, 2024
thiagocrepaldi
approved these changes
Feb 22, 2024
auto-merge was automatically disabled
February 22, 2024 22:51
Pull request was closed
Signed-off-by: liqunfu <[email protected]>
Signed-off-by: liqunfu <[email protected]>
linshokaku
pushed a commit
to linshokaku/onnx
that referenced
this pull request
Oct 2, 2024
…sing: Protobuf_LIBRARIES)". Use Cmake 3.27.9 (onnx#5951) ### Description https://gitlab.kitware.com/cmake/cmake/-/issues/25704 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? --> <!-- - If it fixes an open issue, please link to the issue here. --> --------- Signed-off-by: liqunfu <[email protected]> Signed-off-by: Linsho Kaku <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://gitlab.kitware.com/cmake/cmake/-/issues/25704
Motivation and Context